Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verifyFreezePeriod.yml to ignore milestone promotions #2169

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

sratz
Copy link
Member

@sratz sratz commented Jul 5, 2024

Fixes #2170

@sratz sratz requested review from vogella and HannesWell July 5, 2024 15:04
@sratz sratz force-pushed the sratz-no-freeze-milestone-promotions branch from b0b9cb2 to f0c00c4 Compare July 5, 2024 15:11
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you!

@@ -19,7 +19,7 @@ jobs:
calId="[email protected]"
calURL="https://clients6.google.com/calendar/v3/calendars/group.calendar.google.com/events?calendarId=${calId}&singleEvents=true&timeZone=UTC&maxResults=250&sanitizeHtml=true&timeMin=${today}T00:00:00Z&timeMax=${tomorrow}T00:00:00Z&key=AIzaSyBNlYH01_9Hc5S1J9vuFmu2nUqBZJNAXxs"
echo "Querying calendar https://calendar.google.com/calendar/u/0/embed?src=${calId}"
curl "${calURL}" | grep -i -e "stabilization" -e "signoff" -e "promotion"
curl "${calURL}" | grep -i -P '(stabilization|signoff|(?<!M\d) promotion)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice it were possible to keep the patterns separated and mix regexp and perl-regexp arguments, but to me it looks like this is not possible.

@HannesWell HannesWell merged commit 666f457 into master Jul 7, 2024
4 of 5 checks passed
@HannesWell HannesWell deleted the sratz-no-freeze-milestone-promotions branch July 7, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update verifyFreezePeriod.yml to consider milestone promotions not as error
2 participants